yangsong8-a1 commented on PR #21113: URL: https://github.com/apache/nuttx/pull/21113#issuecomment-6499156350
> `CONFIG_SERIAL_TXBULK` is here to reduce FLASH usage. > > With this PR: > > Board master PR Increase > nucleo-f103rb:nsh 33640 33972 +332 B > stm32f051-discovery:nsh 32648 32988 +340 B > stm32f4discovery:nsh 93368 93520 +152 B > nrf52840-dk:cdcacm 121112 121248 +136 B > It also introduces a bug by removing the `OPOST` check, so NL/CR translation is applied even when `OPOST` is cleared. `cfmakeraw()` clears `OPOST` but leaves `ONLCR` set on console ports, so raw binary output gets corrupted. @raiden00pl Yes, applying this PR will indeed increase code size, but it offers two advantages: first, it improves performance even when `OPOST` (output processing) is enabled for the TTY; second, it integrates blocking logic and unifies code paths, allowing the batch function `uart_putxmitbuffer` to handle operations internally. Is an increase in the amount of code permissible? That was indeed an oversight; the OPOST should have been checked before performing the NL/CR translation. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
