parthitce commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6495082957
> > > we start removing iLLD from the beginning of this year and sync the plan to Infineon in Q3. > > > > > > This PR is opened in June, but you haven't mentioned the concern here that you have a completed version? > > Are you contracted by Infineon? Please sync with Infineon. We are speaking in context for open source NuttX and it's contribution. Why contract matters here? That's private matter. > > > > As I said many times, but I don't see the improvement in your PR(Please compare the change in this and #21110). > > > The patch which changes the current code base must split into small and self-contained patch, instead removing the origin cod base and apply the refresh new one. > > > > > > Feedbacks and reviews are always welcome. We are already splitting the changes in smaller fragments and PR's will be split. But that doesn't answer my primary question, why are you / @zhangyu-duck duplicating the efforts here? > > The problem I mention many time from June: [#19041 (comment)](https://github.com/apache/nuttx/pull/19041#issuecomment-4624907840) [#19041 (comment)](https://github.com/apache/nuttx/pull/19041#issuecomment-4629816156) [#19041 (comment)](https://github.com/apache/nuttx/pull/19041#issuecomment-6477643003) but don't see any improvement. Review happened once. We were waiting for TASKING license and I have mentioned that as well. That doesn't justifies the duplicated efforts! Please stop duplicating the efforts. We can align on a common ground once the primary purpose of the PR is complete. We will have split in a while and pushed as multiple PR's. > > > > Please note the current code base is running on the timing/life critical product. > > > > > > The current code base in upstream doesn't even compile for GCC and tasking! > > that's because the community lack the ci for tricore, but it isn't the reason to remove the code base directly. @zhangyu-duck plan to enable ci after iLLD is dropped smoothly. Removal review was agreed and we were waiting for TASKING License, I mentioned it as well. Regarding the compilation parts, tagging your own comment https://github.com/apache/nuttx/pull/19041#discussion_r4408737918, doesn't it apply for everyone? In short, main breaks for TriCore and you are debating on "EVB and real product with the full functionality (e.g. ZCU/ADD/XCD)" and "timing/life critical product"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
