xiaoxiang781216 commented on code in PR #21143:
URL: https://github.com/apache/nuttx/pull/21143#discussion_r4419469640
##########
fs/vfs/fs_open.c:
##########
@@ -239,6 +239,27 @@ static int file_vopen(FAR struct file *filep, FAR const
char *path,
if (oflags & O_DIRECTORY)
{
ret = dir_allocate(filep, desc.relpath);
+ if (ret >= 0 && (oflags & O_ACCMODE) != O_RDONLY)
Review Comment:
why notchecktheflagbefore dir_allocate
##########
fs/aio/aio_write.c:
##########
@@ -118,6 +118,16 @@ static void aio_write_worker(FAR void *arg)
(FAR const void *)aiocbp->aio_buf,
aiocbp->aio_nbytes,
aiocbp->aio_offset);
+ if (nwritten == -ESPIPE)
Review Comment:
could we dispatch right function directly instead trying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
