Brijesh-Thakkar opened a new pull request, #21155:
URL: https://github.com/apache/nuttx/pull/21155
## Summary
`boards/risc-v/qemu-rv/rv-virt/configs/citest64/run.sh` still has
```
# enable venv
source ${NTFCDIR}/venv/bin/activate
...
# disable venv
deactivate
```
around the NTFC call. This is a dead leftover of 4497bacb1c ("boards: use
NTFC
from pip for citest configs"), which removed these lines from the
sabre-6quad,
qemu-armv8a, rv-virt:citest and sim scripts but missed citest64. CI does not
create `${NTFCDIR}/venv`, so every citest64 run prints two errors:
```
run.sh: line 32: .../nuttx-ntfc/venv/bin/activate: No such file or directory
run.sh: line 44: deactivate: command not found
```
Remove the two lines (and their comments) so that citest64/run.sh matches the
other citest scripts.
## Impact
None besides cleaner logs. Both errors were already harmless: the script has
no
`set -e`, and the NTFC exit status is saved in `$ret` before the `deactivate`
line, so the exit status and the saved artifacts are the same as before.
After
this change the remaining difference between `citest/run.sh` and
`citest64/run.sh` is the `fatfs.img` preparation that rv32 needs.
## Testing
`rv-virt:citest64` built and run with `./tools/ci/cibuild.sh -c -A -N -R -S`
(xPack riscv-none-elf-gcc 14.3.0, ntfc 0.0.3, nuttx-ntfc-testing
`release-0.0.2`, qemu-system-riscv64 10.2.1), log lines containing
`venv/bin/activate` or `deactivate`.
Before (upstream/master):
```
80: + source .../nuttx-ntfc/venv/bin/activate
81: .../citest64/run.sh: line 32: .../nuttx-ntfc/venv/bin/activate: No such
file or directory
334: + deactivate
335: .../citest64/run.sh: line 44: deactivate: command not found
```
After (this change, same flow, run on this branch): no such lines (0
matches).
| | before | after |
|---|---|---|
| passed / failed / skipped | 71 / 0 / 7 | 71 / 0 / 7 |
| NTFC session time | 296.5 s | 300.2 s |
| exit status of the build and test flow | 0 | 0 |
The test results are unchanged, as expected: only the two harmless errors
disappear.
`bash -n citest64/run.sh` passes and `./tools/checkpatch.sh -g
upstream/master..HEAD` passes.
Generated-by: Claude Code (analysis, test runs and drafting); reviewed and
tested by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
