jerpelea opened a new pull request, #21225:
URL: https://github.com/apache/nuttx/pull/21225

   ## Summary
   
   pl011_txint() enabled the TX interrupt and then called uart_xmitchars() with 
interrupts enabled. uart_write() calls it from a task, so the TX interrupt 
could run uart_xmitchars() in the middle of that call. Both moved xmit.tail, 
the tail passed the head, and the driver sent the whole TX buffer again. On the 
console, a program that echoes each key itself printed the last 256 bytes of 
output again with each key.
   
   This PR calls uart_xmitchars() in a critical section, as uart_16550.c does. 
The spinlock still covers only the register access. The first commit fixes the 
two old nxstyle errors in the file (blank lines after declarations), with no 
code change.
   
   ## Impact
   
   RELEASE
   
   ## Testing
   
   CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to