hartmannathan commented on PR #21214: URL: https://github.com/apache/nuttx/pull/21214#issuecomment-6531584857
It's probably not ideal to define `CONFIG_HAVE_EXPRESSION_STATEMENT` in Kconfig, so instead, you could keep the check for GCC, Clang, and Green Hills but use it to define `HAVE_EXPRESSION_STATEMENT`. Then, use `HAVE_EXPRESSION_STATEMENT` to guard the definitions of div_const() and div64_const(). That way, we will have the benefits of `HAVE_EXPRESSION_STATEMENT` being self documenting and 'grep'able, while keeping the automatic detection (avoiding requiring any manual Kconfig changes that people could forget to do). The rest of the change looks good to me. Thanks for finding it and submitting a fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
