Brijesh-Thakkar commented on PR #21212: URL: https://github.com/apache/nuttx/pull/21212#issuecomment-6527538061
Closing this after checking the MemBrowse +8 B on arduino-mega2560. The CI image installs gcc-avr from Ubuntu 22.04 apt, which is avr-gcc 5.4.0. Reproduced locally with the same toolchain and config (arduino-mega2560:nsh, FULLOPT, RTC off): | toolchain | master | this PR | clock_basetime | __muldi3 | |---|---:|---:|---|---| | avr-gcc 5.4.0 (CI) | - | +8 B .text | 114 -> 122 B | still linked | | avr-gcc 14.3.0 | 71462 | 71338 (-124) | 114 -> 72 B | dropped, smaller __umulsidi3 used | avr-gcc 5.4.0 doesn't recognize the 32x32->64 widening multiply, so the cast only adds register zero-fill and still calls __muldi3. Cortex-M0 has no widening multiply instruction either (+4 B with FULLOPT), and Cortex-M3 is unchanged. So on the toolchain NuttX CI uses, this change doesn't pay off. Closing; the measurements are summarized in #18849. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
