Junbo-Zheng opened a new pull request, #21316:
URL: https://github.com/apache/nuttx/pull/21316
## Summary
Five board sources reference Kconfig symbols with wrong case in
`#ifdef` guards, so the condition is permanently false and the
guarded code never compiles. All five are latent: no in-tree
defconfig currently enables these options, but the Kconfigs are
user-selectable (`bool`, `default n`), so anyone turning them on
silently loses the board hooks.
## Impact
- **Users**: nrf52832-dk, nrf52840-dk, thingy53, thingy91 will now
compile their `spi2select`/`spi2status` board hooks when
`CONFIG_NRFxx_SPI2_MASTER=y`. arduino-due's LED-vs-ITEAD-SD
`#error` guard (protecting against pin conflict with
`sam_mmcsd.c`) will now actually fire when both are enabled.
- **Build**: None -- the guarded code was previously unreachable, so
no in-tree config changes behavior.
- **Hardware**: nrf52832-dk, nrf52840-dk, thingy53, thingy91,
arduino-due.
- **Documentation**: None.
- **Security & Compatibility**: None -- no API, ABI, or symbol-table
change.
## Testing
No in-tree defconfig currently enables these options, so there is
no board image whose boot behavior changes. Verified mechanically:
- `grep -rn
'CONFIG_nrf5[23]_SPI2_MASTER\|CONFIG_nrf91_SPI2_MASTER\|CONFIG_ARCH_LEDs'
boards/`
returns zero real `#ifdef` matches after the fix (remaining hits
are prose comments on other boards, unrelated).
Signed-off-by: Junbo Zheng <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
