xiaoxiang781216 commented on code in PR #21140: URL: https://github.com/apache/nuttx/pull/21140#discussion_r4432636116
########## arch/arm/src/armv6-m/arm_svcall.c: ########## @@ -67,6 +67,15 @@ int arm_svcall(int irq, void *context, void *arg) cmd = regs[REG_R0]; +#ifdef CONFIG_BUILD_PROTECTED + if ((regs[REG_CONTROL] & CONTROL_NPRIV) != 0 && Review Comment: why need add this check ########## arch/arm/include/syscall.h: ########## @@ -122,7 +122,9 @@ * void signal_handler_return(void); */ -#define SYS_signal_handler_return (7) +#ifdef __ASSEMBLY__ Review Comment: why add iifdef ########## arch/arm/include/syscall.h: ########## @@ -122,7 +122,9 @@ * void signal_handler_return(void); */ -#define SYS_signal_handler_return (7) +#ifdef __ASSEMBLY__ +# define SYS_signal_handler_return CONFIG_SYS_RESERVED Review Comment: why change to CONFIG_SYS_RESERVED, please control your AI model, don't make the unnessary change and review the change carefully before updating PR, which just waste CI resource and maintainer time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
