This is an automated email from the ASF dual-hosted git repository. xiaoxiang781216 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 474eab997b0cf926f42ae69390ebb2e69b5a2a97 Author: Marco Casaroli <[email protected]> AuthorDate: Tue Oct 20 20:45:01 2026 +0200 include/limits.h: Define LOGIN_NAME_MAX. POSIX requires LOGIN_NAME_MAX in <limits.h>, and sysconf() lists _SC_LOGIN_NAME_MAX. getlogin() returns at most NAME_MAX bytes, so define LOGIN_NAME_MAX as NAME_MAX + 1 (the terminating null included) and size the getlogin() buffer with it. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <[email protected]> --- include/limits.h | 1 + libs/libc/pwd/lib_getlogin.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/limits.h b/include/limits.h index e71d96e6ac6..44140a1e3e8 100644 --- a/include/limits.h +++ b/include/limits.h @@ -146,6 +146,7 @@ #define MAX_INPUT _POSIX_MAX_INPUT #define NAME_MAX CONFIG_NAME_MAX #define TTY_NAME_MAX NAME_MAX +#define LOGIN_NAME_MAX (NAME_MAX + 1) #if defined(CONFIG_SCHED_NGROUPS) && CONFIG_SCHED_NGROUPS > 0 # define NGROUPS_MAX CONFIG_SCHED_NGROUPS diff --git a/libs/libc/pwd/lib_getlogin.c b/libs/libc/pwd/lib_getlogin.c index 0bc1efe9e90..b79f4128ea3 100644 --- a/libs/libc/pwd/lib_getlogin.c +++ b/libs/libc/pwd/lib_getlogin.c @@ -99,7 +99,7 @@ int getlogin_r(FAR char *buf, size_t bufsize) FAR char *getlogin(void) { - static char name[NAME_MAX + 1]; + static char name[LOGIN_NAME_MAX]; int ret; ret = getlogin_r(name, sizeof(name));
