xiaoxiang781216 commented on code in PR #21152:
URL: https://github.com/apache/nuttx/pull/21152#discussion_r4434910505
##########
sched/group/group_signal.c:
##########
@@ -153,7 +155,8 @@ static int group_signal_handler(pid_t pid, FAR void *arg)
* blocking the signal will receive the signal.
*/
- ret = nxsig_tcbdispatch(tcb, info->siginfo, true);
+ ret = nxsig_tcbdispatch_source(tcb, info->siginfo, true,
+ info->source);
Review Comment:
align
##########
sched/signal/sig_dispatch.c:
##########
@@ -813,7 +857,21 @@ int nxsig_tcbdispatch(FAR struct tcb_s *stcb, siginfo_t
*info,
}
/****************************************************************************
- * Name: nxsig_dispatch
+ * Name: nxsig_tcbdispatch
+ *
+ * Description:
+ * nxsig_tcbdispatch_source() for a signal that no POSIX timer sends.
+ *
+ ****************************************************************************/
+
+int nxsig_tcbdispatch(FAR struct tcb_s *stcb, FAR siginfo_t *info,
Review Comment:
why not add source to nxsig_tcbdispatch directly and remove
nxsig_tcbdispatch_source
##########
sched/signal/sig_notification.c:
##########
@@ -160,8 +161,9 @@ int nxsig_event_valid(FAR const struct sigevent *event)
*
****************************************************************************/
-int nxsig_notification(pid_t pid, FAR struct sigevent *event,
- int code, FAR struct sigwork_s *work)
+int nxsig_notification_source(pid_t pid, FAR struct sigevent *event,
Review Comment:
ditto
##########
sched/signal/sig_dispatch.c:
##########
@@ -865,9 +926,85 @@ int nxsig_dispatch(pid_t pid, FAR siginfo_t *info, bool
thread)
if (stcb != NULL)
{
- return nxsig_tcbdispatch(stcb, info, false);
+ return nxsig_tcbdispatch_source(stcb, info, false, source);
}
}
return -ESRCH;
}
+
+/****************************************************************************
+ * Name: nxsig_dispatch
+ *
+ * Description:
+ * nxsig_dispatch_source() for a signal that no POSIX timer sends.
+ *
+ ****************************************************************************/
+
+int nxsig_dispatch(pid_t pid, FAR siginfo_t *info, bool thread)
Review Comment:
why not add source to nxsig_dispatch directly and remove
nxsig_dispatch_source too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
