casaroli commented on code in PR #3605: URL: https://github.com/apache/nuttx-apps/pull/3605#discussion_r4435139508
########## crypto/openssl_mbedtls_wrapper/mbedtls/ssl_pm.c: ########## @@ -44,6 +44,20 @@ #define X509_INFO_STRING_LENGTH 8192 #define READ_TIMEOUT_MS 50000 /* 50 seconds */ +#define SSL_COMPAT_NAME2(a, b) a ## _ ## b Review Comment: These macros only hide the OpenSSL names (client_CA, X509_VERIFY_PARAM_set1_host, SSL_get0_alpn_selected and others) from nxstyle; after expansion the names are the same, but grep no longer finds the definitions. Fix: keep only the move of ssl_mem_free() after SSL_DEBUG() (and the typo fix), and put the OpenSSL names in the nxstyle whitelist if the check still fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
