casaroli commented on code in PR #3859: URL: https://github.com/apache/nuttx-apps/pull/3859#discussion_r4435138678
########## interpreters/duktape/Makefile: ########## @@ -49,6 +49,7 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/console CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT +CFLAGS += -DDUK_CMDLINE_SIGNAL Review Comment: signal() is built only with CONFIG_ENABLE_ALL_SIGNALS (libs/libc/signal/Make.defs, sig_signal.c). With CONFIG_ENABLE_PARTIAL_SIGNALS (the default with DEFAULT_SMALL) or CONFIG_DISABLE_ALL_SIGNALS, set_sigint_handler() does not link. Fix: add -DDUK_CMDLINE_SIGNAL only when CONFIG_ENABLE_ALL_SIGNALS=y. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
