v01d opened a new pull request #397: URL: https://github.com/apache/incubator-nuttx-apps/pull/397
## Summary Before this change CLEANDIRS was used, which is built from detecting dummy .depend/.kconfig files, which is problematic since when there's an intermediate subdirectory which does not have it, subdirectories below this level will not be found (even if they do have these files). Since we already know exactly which subdirectories we need to clean based on configured apps, we directly clean over these. I started looking into this since I found that the `btsak` application was not being cleaned due to this reason, which sits at `apps/wireless/bluetooth/btsak` and `bluetooth` was not being cleaned since there were none of this dummy files there. I would like to hear your thoughts on why this might be wrong or not. I feel there's quite a bit of "magic files" placed around and these are used to drive many targets and this is becoming very confusing to maintain. My reasoning is that we should go into the subdirectories we know need cleaning from the top-level Makefile directly and then let each application Makefile drive the cleaning using its `clean` target. I have not changed yet the similar logic in `Directory.mk` for `CLEANSUBDIRS` which is still driven by `.depend` and `.kconfig` files as it is not clear to me how works. I'm guessing that after this change, it is not necessary, but I'm unsure. ## Impact Application build system ## Testing Building and cleaning and looking for leftover `.o`s ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
