casaroli commented on code in PR #21188: URL: https://github.com/apache/nuttx/pull/21188#discussion_r4439722510
########## arch/tricore/src/cmake/gcc.cmake: ########## @@ -202,3 +202,7 @@ endif() if(CONFIG_DEBUG_LINK_ORPHAN_WARN) add_link_options(-Wl,--orphan-handling=warn) endif() + +if(NOT CONFIG_ARCH_HAVE_FPU) Review Comment: This append has no effect: chip.cmake, included at line 34, already passed PLATFORM_FLAGS to add_compile_options() and add_link_options(), and nothing reads PLATFORM_FLAGS after this line. Fix: remove these three lines (tc3xx does not select ARCH_HAVE_FPU, so making them work would switch the tc3xx GNU build to soft float). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
