xiaoxiang781216 commented on code in PR #3973:
URL: https://github.com/apache/nuttx-apps/pull/3973#discussion_r4469705247
##########
system/flatbuffers/flatbuffers.patch:
##########
@@ -20,27 +19,26 @@ index 5c4cae79..1a631641 100644
// If activate should be declared and included first.
diff --git a/include/flatbuffers/default_allocator.h
b/include/flatbuffers/default_allocator.h
-index d4724122..975d9380 100644
---- a/include/flatbuffers/default_allocator.h
-+++ b/include/flatbuffers/default_allocator.h
-@@ -39,24 +39,18 @@ class DefaultAllocator : public Allocator {
+--- a/include/flatbuffers/default_allocator.h 2025-09-24 05:18:02.000000000
+0000
++++ b/include/flatbuffers/default_allocator.h 2026-11-04 13:31:39.230535284
+0000
+@@ -39,24 +39,18 @@
// This is to avoid having a statically or dynamically allocated default
// allocator, or having to move it between the classes that may own it.
- inline uint8_t *Allocate(Allocator *allocator, size_t size) {
+ inline uint8_t* Allocate(Allocator* allocator, size_t size) {
- return allocator ? allocator->allocate(size)
- : DefaultAllocator().allocate(size);
Review Comment:
why need change
##########
mlearning/tflite-micro/0004-tflite-add-extern-C-to-main-function-to-avoid-c-mang.patch:
##########
@@ -5,22 +5,16 @@ Subject: [PATCH] tflite: add extern "C" to main function to
avoid c++ mangling
Signed-off-by: chao an <[email protected]>
---
- tensorflow/lite/micro/examples/hello_world/hello_world_test.cc | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
diff --git a/tensorflow/lite/micro/examples/hello_world/hello_world_test.cc
b/tensorflow/lite/micro/examples/hello_world/hello_world_test.cc
-index ec23571a..24982e90 100644
+index 83bd2f2..1e1f8fe 100644
--- a/tensorflow/lite/micro/examples/hello_world/hello_world_test.cc
+++ b/tensorflow/lite/micro/examples/hello_world/hello_world_test.cc
-@@ -149,7 +149,7 @@ TfLiteStatus LoadQuantModelAndPerformInference() {
+@@ -148,7 +148,7 @@ TfLiteStatus LoadQuantModelAndPerformInference() {
Review Comment:
why change
##########
system/flatbuffers/flatbuffers.patch:
##########
@@ -20,27 +19,26 @@ index 5c4cae79..1a631641 100644
// If activate should be declared and included first.
diff --git a/include/flatbuffers/default_allocator.h
b/include/flatbuffers/default_allocator.h
-index d4724122..975d9380 100644
---- a/include/flatbuffers/default_allocator.h
-+++ b/include/flatbuffers/default_allocator.h
-@@ -39,24 +39,18 @@ class DefaultAllocator : public Allocator {
+--- a/include/flatbuffers/default_allocator.h 2025-09-24 05:18:02.000000000
+0000
++++ b/include/flatbuffers/default_allocator.h 2026-11-04 13:31:39.230535284
+0000
+@@ -39,24 +39,18 @@
// This is to avoid having a statically or dynamically allocated default
// allocator, or having to move it between the classes that may own it.
- inline uint8_t *Allocate(Allocator *allocator, size_t size) {
+ inline uint8_t* Allocate(Allocator* allocator, size_t size) {
- return allocator ? allocator->allocate(size)
- : DefaultAllocator().allocate(size);
+ return allocator->allocate(size);
}
- inline void Deallocate(Allocator *allocator, uint8_t *p, size_t size) {
+ inline void Deallocate(Allocator* allocator, uint8_t* p, size_t size) {
- if (allocator)
- allocator->deallocate(p, size);
- else
- DefaultAllocator().deallocate(p, size);
Review Comment:
ditto
##########
mlearning/tflite-micro/tflite-micro.patch:
##########
@@ -10,11 +10,8 @@ Patch files in tflite-micro
Change-Id: Ic683fe4f12221d214ca77515c7b9487bb76a923f
Signed-off-by: renzhiyuan1 <[email protected]>
---
- signal/src/circular_buffer.cc | 2 ++
Review Comment:
why need keep this patch
##########
system/flatbuffers/flatbuffers.patch:
##########
@@ -20,27 +19,26 @@ index 5c4cae79..1a631641 100644
// If activate should be declared and included first.
diff --git a/include/flatbuffers/default_allocator.h
b/include/flatbuffers/default_allocator.h
-index d4724122..975d9380 100644
---- a/include/flatbuffers/default_allocator.h
-+++ b/include/flatbuffers/default_allocator.h
-@@ -39,24 +39,18 @@ class DefaultAllocator : public Allocator {
+--- a/include/flatbuffers/default_allocator.h 2025-09-24 05:18:02.000000000
+0000
++++ b/include/flatbuffers/default_allocator.h 2026-11-04 13:31:39.230535284
+0000
+@@ -39,24 +39,18 @@
// This is to avoid having a statically or dynamically allocated default
// allocator, or having to move it between the classes that may own it.
- inline uint8_t *Allocate(Allocator *allocator, size_t size) {
+ inline uint8_t* Allocate(Allocator* allocator, size_t size) {
Review Comment:
why change the format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
