xiaoxiang781216 commented on code in PR #21428:
URL: https://github.com/apache/nuttx/pull/21428#discussion_r4471808736
##########
sched/clock/clock_perf.c:
##########
@@ -31,13 +31,25 @@
#include <nuttx/spinlock.h>
#include <nuttx/wdog.h>
-#ifndef CONFIG_ARCH_PERF_EVENTS_USER_ACCESS
-
/****************************************************************************
* Preprocessors
****************************************************************************/
-# if defined(CONFIG_PERF_OVERFLOW_CORRECTION) && ULONG_MAX != UINT64_MAX
+/* Use up_perf_*() only when they count: the arch starts its counter with
+ * ARCH_PERF_EVENTS, and arch_alarm.c / arch_timer.c provide them when the
+ * arch has no counter. Else use the system ticks.
+ */
+
+#if defined(CONFIG_ARCH_PERF_EVENTS) || \
+ defined(CONFIG_ARCH_PERF_EVENTS_USER_ACCESS) || \
+ (!defined(CONFIG_ARCH_HAVE_PERF_EVENTS) && \
+ (defined(CONFIG_ALARM_ARCH) || defined(CONFIG_TIMER_ARCH)))
Review Comment:
```
#if defined(CONFIG_ARCH_PERF_EVENTS) || \
defined(CONFIG_ALARM_ARCH) || defined(CONFIG_TIMER_ARCH)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
