hartmannathan commented on code in PR #21476:
URL: https://github.com/apache/nuttx/pull/21476#discussion_r4480359403


##########
include/nuttx/net/mii.h:
##########
@@ -960,10 +970,49 @@
 
 /* YT8512 Register 0x15: Rx error counter */
 
+/* RTL8201F register bit settings *******************************************/
+
+#define MII_PHYID1_RTL8201F            0x001c      /* ID1 value for Realtek 
RTL8201F */
+#define MII_PHYID2_RTL8201F            0xc816      /* ID2 value for Realtek 
RTL8201F */
+#define MII_RTL8201F_MCR_SPEED_MASK    0x2000
+#define MII_RTL8201F_MCR_10MBPS        0x00
+#define MII_RTL8201F_MCR_100MBPS       0x2000
+#define MII_RTL8201F_MCR_DUPLEX        0x100
+#define MII_RTL8201F_RMII_SEL          (1 << 3)
+#define MII_RTL8201F_TXC_REF_CLK_DIR   (1 << 12)
+#define MII_RTL8201F_RMII_TX_DELAY(n)  (((n) & 0x0f) << 8) /* Set TX delay */
+#define MII_RTL8201F_RMII_RX_DELAY(n)  (((n) & 0x0f) << 4) /* Set RX delay */
+
 /****************************************************************************
  * Type Definitions
  ****************************************************************************/
 
+enum phy_iftype_e
+{
+  PHY_TYPE_MII = 0,
+  PHY_TYPE_GMII,
+  PHY_TYPE_RMII,
+  PHY_TYPE_RGMII
+};
+
+struct phy_desc_s;
+
+struct mdio_ops_s

Review Comment:
   Did you intend to call the new struct `mii_ops_s` or something like that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to