xiaoxiang781216 commented on PR #21510: URL: https://github.com/apache/nuttx/pull/21510#issuecomment-6683782613
> > > we already agree that PR split will be done by us. > > > > > > why? it isn't related to iLLD drop. it's open-source project, anyone could improve it as needed. > > changes in this PR are already covered in initial PR, we mutually agreed to a point avoid duplication of work and we continue split of initial PR from our end. [d42669c](https://github.com/apache/nuttx/commit/d42669c805bf70f27998245b7a12920f95880012) > > [d42669c#diff-62b8ccb716fcc4c072da138049123478c3bff92308c22384152389fc28542f5fR82](https://github.com/apache/nuttx/commit/d42669c805bf70f27998245b7a12920f95880012#diff-62b8ccb716fcc4c072da138049123478c3bff92308c22384152389fc28542f5fR82) I don't see your code change Makefile like: https://github.com/apache/nuttx/pull/21510/changes#diff-1c370c487a863b9b6a62a181e9816f1f2a5a8799e93392efba09818b972fee3aR171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
