casaroli commented on code in PR #21358:
URL: https://github.com/apache/nuttx/pull/21358#discussion_r4467823826
##########
mm/kasan/sw_tags.c:
##########
@@ -68,6 +66,18 @@ static spinlock_t g_lock;
* Private Functions
****************************************************************************/
+static inline uint8_t kasan_random_tag(void)
+{
+ /* Use a simple LCG that does not depend on TLS (rand() requires
Review Comment:
qemu-armv8a:sw_tags on current master boots to NSH and `kasantest` gives the
same result as this PR (aarch64-none-elf-gcc 14.2: 32 pass, `heap illegal
strncpy` fails on both), so the early boot crash in the comment, the commit
message and the PR body is not in master.
Fix: remove the crash claim from all three and keep the real gain: KASAN no
longer changes the `rand()` sequence of the application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
