anchao commented on PR #21061:
URL: https://github.com/apache/nuttx/pull/21061#issuecomment-6620311946
> 1. The Testing section says only "sim/nsh" and has no log. `sim:nsh` does
not build `timer.c` (no `CONFIG_TIMER`), does not open `/dev/oneshot`, and is
not tickless, so none of the changed code runs.
>
> Fix: add a runtime log from a configuration that uses `/dev/timer` or
`/dev/oneshot` with poll and a signal, and from a tickless configuration with
`CONFIG_ALARM_ARCH`.
>
> 2. The PR body has no Impact section. CONTRIBUTING 1.7.1 requires all
fields of the template in 2.3.
>
> Fix: add the Impact section.
I added the timer/oneshot related configs to sim:ostest so the existing
timer tests are now built for this configuration.
The added coverage enables:
- POSIX timer test with SIGEV_SIGNAL/SI_TIMER
- SIGEV_THREAD timer test
- cmocka driver timer test
- cmocka oneshot test, including OSIOC_START / OSIOC_CURRENT / OSIOC_CANCEL
paths
I verified the sim:ostest build successfully. I also ran ostest on sim and
it completed successfully with:
ostest_main: Exiting with status 0
The relevant POSIX timer path delivered all expected SI_TIMER notifications,
and the SIGEV_THREAD timer test completed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
