imeghar2408-max commented on PR #3840: URL: https://github.com/apache/nuttx-apps/pull/3840#issuecomment-6691391295
> Commit [6c38233](https://github.com/apache/nuttx-apps/commit/6c38233b99b9fff1c8226d39368a2bf6cda229e2) still removes the blank line after `DEBUGASSERT(errcode > 0);` in `nxplayer_enqueuebuffer()`, `nxplayer_fforward()` and `nxplayer_rewind()` of system/nxplayer/nxplayer.c; [b143f1f](https://github.com/apache/nuttx-apps/commit/b143f1f318c897a3076c85b0665a6b0e3546beb1) keeps it there. > > Fix: drop these three hunks from [6c38233](https://github.com/apache/nuttx-apps/commit/6c38233b99b9fff1c8226d39368a2bf6cda229e2). > > The message of [b143f1f](https://github.com/apache/nuttx-apps/commit/b143f1f318c897a3076c85b0665a6b0e3546beb1) has `Co-authored-by: Copilot` and no `Assisted-by:`. CONTRIBUTING 1.5 requires `Assisted-by: AGENT_NAME:MODEL_VERSION` above the signature on every commit that used such a tool. > > Fix: add the `Assisted-by:` line above `Signed-off-by` in [b143f1f](https://github.com/apache/nuttx-apps/commit/b143f1f318c897a3076c85b0665a6b0e3546beb1). @casaroli Thanks for the review! I've addressed both points and pushed the updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
