casaroli commented on code in PR #3983: URL: https://github.com/apache/nuttx-apps/pull/3983#discussion_r4501776117
########## testing/drivers/drivertest/drivertest_watchdog.c: ########## @@ -60,6 +60,11 @@ #define WDG_DEFAULT_TIMEOUT 2000 #define WDG_DEFAULT_TESTCASE 0 #define WDG_DEFAULT_DEVIATION 20 +#ifdef CONFIG_ARCH_CHIP_ESP32S3 Review Comment: On upstream the ESP32-S3 branch is never built: only boards/arm/n32h7 and boards/arm/samv7 provide `board_reset_cause()`, so `CONFIG_BOARDCTL_RESET_CAUSE` does not link on ESP32-S3. Fix: drop the chip check and let the caller give the expected reset cause, for example with a new command-line option next to `-a`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
