casaroli commented on code in PR #3988: URL: https://github.com/apache/nuttx-apps/pull/3988#discussion_r4501775614
########## wireless/bluetooth/nimble/CMakeLists.txt: ########## @@ -23,6 +23,14 @@ if(CONFIG_NIMBLE) nuttx_add_library(nimble) + if(CONFIG_ESPRESSIF_BLE) Review Comment: Only the CMake build gets the rename. With Make, the NimBLE sources are compiled by each example through `Makefile.nimble`, which has no such definitions, so the same ESP32-C6 configuration still fails to link with Make. Fix: add the same three `-D` options to `CFLAGS` in `wireless/bluetooth/nimble/Makefile.nimble` under `ifneq ($(CONFIG_ESPRESSIF_BLE),)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
