casaroli commented on code in PR #21511:
URL: https://github.com/apache/nuttx/pull/21511#discussion_r4501769933
##########
arch/tricore/src/common/Make.defs:
##########
@@ -22,6 +22,12 @@
HEAD_CSRC += tricore_doirq.c
+ifeq ($(CONFIG_ARCH_TOOLCHAIN_TASKING),y)
+CMN_ASRCS += tricore_head.asm
Review Comment:
With the TASKING toolchain and make, `tricore_head.asm` is never assembled:
arch/tricore/src/Makefile maps only `.S` (`AOBJS = $(ASRCS:.S=$(OBJEXT))` and
the rule `%$(OBJEXT): %.S`), so make reports "doesn't match the target pattern"
and `__start` is missing at link time. The Testing section lists CMake builds
only.
Fix: make arch/tricore/src/Makefile use `$(ASMEXT)` for ASRCS and its rule
(as #21496 does), and build the TASKING configs with make too.
##########
arch/tricore/include/arch.h:
##########
@@ -58,10 +58,36 @@
__val; \
})
+/* TriCore core special function register (CSFR) */
+
+#define CPU_PSW 0xFE04 /* Program Status Word */
Review Comment:
`CPU_PSW`, `CPU_FCX` and the other new CSFR defines repeat what arch/csfr.h
(included by this header) already has as `TRICORE_CPU_PSW` and
`TRICORE_CPU_FCX`.
Fix: add the missing offsets (CORE_ID, BIV, BTV, ISP, LCX, VCON0) to
arch/csfr.h with the `TRICORE_CPU_` prefix and use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
