casaroli commented on code in PR #3962:
URL: https://github.com/apache/nuttx-apps/pull/3962#discussion_r4455256063
##########
system/gdbstub/gdbstub.c:
##########
@@ -225,16 +261,19 @@ int main(int argc, FAR char *argv[])
do
{
ret = gdb_process(state, 0, NULL);
- if (ret == -ECONNRESET)
- {
#ifdef CONFIG_NET
- if (port)
- {
- close(fd);
- goto reconnect;
- }
+ if (ret < 0 && port)
Review Comment:
On a tty an error also ends the session: the loop stops (`while (ret >=
0)`), gdbstub calls gdb_state_uninit() and exits, so nothing resumes the old
state. Only the TCP case waits for a new client, with a new state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
