casaroli commented on code in PR #21342:
URL: https://github.com/apache/nuttx/pull/21342#discussion_r4456900316
##########
include/nuttx/spinlock.h:
##########
@@ -641,7 +706,7 @@ static inline_function bool rspin_trylock(FAR rspinlock_t
*lock)
# define rspin_trylock_irqsave(l, f) \
({ \
(void)(l); \
- (f) = up_irq_save(); \
+ (f) = irq_save(); \
Review Comment:
This line still has `(f) = irq_save();`, and `irq_save()` does not exist
(`git grep -w irq_save` finds only this line; master has `up_irq_save()` here).
With CONFIG_SPINLOCK off, `rspin_trylock_irqsave()` fails with "implicit
declaration of function 'irq_save'" (qemu-armv8a:nsh with SPINLOCK disabled,
this head).
Fix: `(f) = up_irq_save(); \` at this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
