anchao commented on PR #21340:
URL: https://github.com/apache/nuttx/pull/21340#issuecomment-6762173928

   @casaroli 
       I rebased the branch on the current apache/master and force-pushed the 
updated version.                                                                
                      
                                                                                
                                                                                
                    
       ```text                                                                  
                                                                                
                    
       base: 3fd185111fdb47b8bae0ea452f8b0e13ab9d579e                           
                                                                                
                    
       head: a873b929fe9cd104da60e0144f941b7a3c78b994                           
                                                                                
                    
                                                                                
                                                                                
                    
     I also added a small follow-up optimization to reduce the field helper 
overhead without forcing it inline. In my local test, forcing 
vsprintf_put_field() inline increased text size, so the new version instead 
passes the width by value and keeps the left-padding tail adjustment in the 
callers that need it.                                             
                                                                                
                                                                                
                    
     I reran size/stack measurements on nucleo-f072rb:nsh with 
arm-none-eabi-gcc 13.3.1.                                                       
                                     
                                                                                
                                                                                
                    
     For the default non-floating-point -Os path:                               
                                                                                
                    
                                                                                
                                                                                
                    
       text: 47,352 -> 47,444  (+92)                                            
                                                                                
                    
       deepest stack from lib_vsprintf(): 184 -> 192  (+8)                      
                                                                                
                    
                                                                                
                                                                                
                    
     For the floating-point -Os path with CONFIG_LIBM_TOOLCHAIN=y and 
CONFIG_LIBC_FLOATINGPOINT=y:                                                    
                              
                                                                                
                                                                                
                    
       text: 49,768 -> 49,864  (+96)                                            
                                                                                
                    
       deepest stack from lib_vsprintf(): 396 -> 396  (0)                       
                                                                                
                    
                                                                                
                                                                                
                    
     I will update the PR description with the current test configuration and 
full result tables.                                                             
                      
                                                                                
                                                                                
                    
     I also understand your point about avoiding broken intermediate commits 
for the trailing % behavior. I will review the commit history before the final 
version so that each commit preserves the expected behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to