xiaoxiang781216 commented on code in PR #21607:
URL: https://github.com/apache/nuttx/pull/21607#discussion_r4533420916


##########
arch/arm/src/gd32f4/gd32f4xx_syscfg.c:
##########
@@ -32,6 +32,7 @@
 
 #include <nuttx/debug.h>
 #include <nuttx/irq.h>
+#include <assert.h>

Review Comment:
   move after  line 31



##########
drivers/lcd/lcd_dev.c:
##########
@@ -33,6 +33,7 @@
 #include <errno.h>
 #include <nuttx/debug.h>

Review Comment:
   move after line 37



##########
fs/mnemofs/mnemofs.c:
##########
@@ -62,6 +62,7 @@
 #include <string.h>
 #include <sys/statfs.h>
 #include <assert.h>
+#include <nuttx/mutex.h>

Review Comment:
   move after line 59



##########
net/nat/nat.c:
##########
@@ -25,6 +25,7 @@
  ****************************************************************************/
 
 #include <nuttx/config.h>
+#include <nuttx/mutex.h>
 

Review Comment:
   move blank line before line 28



##########
arch/arm/src/mx8mp/mx8mp_i2c.c:
##########
@@ -33,6 +33,7 @@
 #include "hardware/mx8mp_i2c.h"
 
 #include <nuttx/debug.h>
+#include <assert.h>

Review Comment:
   move line 35/36 after line 29 and ad blank line before assert.h



##########
fs/mnemofs/mnemofs_ctz.c:
##########
@@ -58,6 +58,7 @@
 #include <nuttx/kmalloc.h>

Review Comment:
   move after line 62



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to