Brijesh-Thakkar commented on code in PR #21537:
URL: https://github.com/apache/nuttx/pull/21537#discussion_r4536923682


##########
libs/libc/stream/lib_libbsprintf.c:
##########
@@ -142,6 +151,41 @@ int lib_bsprintf(FAR struct lib_outstream_s *s, FAR const 
IPTR char *fmt,
 
           infmt = false;
         }
+#ifdef CONFIG_LIBC_BFORMAT_B16
+      else if (strchr("aAeEfFgG", c) != NULL && *(fmt - 2) == 'h')

Review Comment:
   Yes, overloading %hf was not correct. 
   Suggested a separate B16 converter for the main thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to