imeghar2408-max commented on PR #21734: URL: https://github.com/apache/nuttx/pull/21734#issuecomment-6806663586
> @imeghar2408-max AFAIK SIMulator is not a good place to test it because it doesn't have any analog device or analog support. You need a real board (STM32, ESP32, SAMV7, etc) with ANALOG support to test it correctly. Thanks for the suggestion! I agree that the simulator isn't suitable for testing an actual ADC peripheral or a hardware-specific lower-half driver. In this case, though, the regression test uses a mock ADC lower half and exercises the real VFS "open()" / "close()" path. The mock makes the first "ao_setup()" return "-EIO" and the subsequent call succeed. This lets us verify that a failed setup doesn't increment "ad_ocount", and that a later open correctly retries the setup. So the simulator is only being used to run this upper-half regression test; i think it doesn't need to provide actual analog hardware?? Would you still expect an additional board-level test? I would test it on board if you say so...!? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
