yangsong8-a1 opened a new pull request, #21837:
URL: https://github.com/apache/nuttx/pull/21837

   ## Summary
   
   The work queue keepalive of the watchdog auto-monitor always used LPWORK.
   A task that runs above the low priority work queue then starves the
   keepalive and the watchdog resets the system, even though nothing hangs.
   
   - Replace CONFIG_WATCHDOG_AUTOMONITOR_BY_WORKER with
     CONFIG_WATCHDOG_AUTOMONITOR_BY_LPWORK (same behavior as before) and
     CONFIG_WATCHDOG_AUTOMONITOR_BY_HPWORK (keepalive on HPWORK).
   - Switch sim:taskmonitor and the watchdog documentation to BY_LPWORK.
   
   ## Impact
   
   CONFIG_WATCHDOG_AUTOMONITOR_BY_WORKER is renamed. Out-of-tree configs that
   set it must select CONFIG_WATCHDOG_AUTOMONITOR_BY_LPWORK instead. In tree,
   only sim:taskmonitor used it; its generated .config is unchanged apart
   from the option name, and `make savedefconfig` reproduces the defconfig.
   
   ## Testing
   
   Ubuntu 22.04, gcc 13.1.
   
   sim:taskmonitor: the watchdog (watchdog_wdog, 5 s timeout, powers off with
   status 77 when it expires) is fed by the auto-monitor. After 8 s idle, a
   test program spins for 8 s at priority 150, above LPWORK (100) and below
   HPWORK (224):
   
   | | apache/master (BY_WORKER) | This PR, BY_LPWORK | This PR, BY_HPWORK |
   |---|---|---|---|
   | 8 s idle | fed | fed | fed |
   | 8 s busy at priority 150 | `Watchdog expired`, exit 77 | `Watchdog 
expired`, exit 77 | still fed, `still alive`, exit 0 |
   
   Also built without new warnings: sim:nsh, sim:watchdog,
   sim:watchdog-notifier, sim:ostest, stm32f746-ws:nsh,
   sam4s-xplained-pro:nsh, olimexino-stm32:nsh.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to