patacongo edited a comment on issue #1880:
URL:
https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869
Aha... these bad directories are being created by configure.sh.
$ make distclean (and verify that there are no chip or board directories)
$ tools/configure.sh -c stm32f4discovery:nsh
$ find . -name board
./arch/arm/include/board
./arch/arm/src/board
./boards/arm/stm32/common/board
$ find . -name chip
./arch/arm/include/chip
./arch/arm/src/chip
@v01d @btashton This is a consequence of several changes to the Makefiles
recently:
- The olddefconfig target used to invoke the clean_context target to remove
all residuals from the configuration
- The symbolic links are (probably) created because CONFIG_CYGWIN_WINTOOL
has not been selected yet in the configuration (it was initially a Linux
configuration). The .config included by the Makefile is the original defconfig
file and does not yet have the derived settings like CONFIG_CYGWIN_WINTOOL.=y.
So the Makefile runs without sufficient information.
- The logic that removes these incorrect links was removed from its correct
location in the clean_context target to the distclean target.
A possible fix would be to restore the 'make clean_context' and all
reconfigurations to eliminate this garbage from running the Makefile with an
incomplete configuration. The old, fully working logic in Makefile.unix was:
do_olddefconfig: dirlinks apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig
olddefconfig: do_olddefconfig clean_context
Where clean_context removed the bad settings left by the 'make olddefconfig'
setup. Restoring this code would not fully work, however. You would also have
to restore the correct behavior or clean_context since the key clean up was
more to the distclean target.
These are the commits that broke the Cygwin build: b5dc83748c0 and
c709ed24646 Parts of those changes need to be reverted.
I will never understand why people intentionally break full working, well
tested code with no real justification.
@xiaoxiang781216 Can you discuss this with @liuguo09 and @anchao? It is
their commits together that break the Cygwin build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
