xiaoxiang781216 commented on code in PR #21865:
URL: https://github.com/apache/nuttx/pull/21865#discussion_r4578828043


##########
arch/risc-v/src/rustsbi/Kconfig:
##########
@@ -0,0 +1,16 @@
+config RUSTSBI
+       bool "Build RustSBI firmware"
+       depends on ARCH_CHIP_QEMU_RV64 && ARCH_BOARD_QEMU_RV_VIRT

Review Comment:
   why depend on qemu?



##########
arch/risc-v/src/rustsbi/Kconfig:
##########
@@ -0,0 +1,16 @@
+config RUSTSBI
+       bool "Build RustSBI firmware"
+       depends on ARCH_CHIP_QEMU_RV64 && ARCH_BOARD_QEMU_RV_VIRT
+       depends on ARCH_USE_S_MODE && BUILD_KERNEL && !NUTTSBI && !OPENSBI

Review Comment:
   should we change XXXSBI to choice?



##########
arch/risc-v/src/rustsbi/Make.defs:
##########
@@ -0,0 +1,48 @@
+############################################################################
+# arch/risc-v/src/rustsbi/Make.defs

Review Comment:
   how about move the current implantation of sbi into arch/riscv-v/sbi by a 
new pr first?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to