ThePassionate opened a new pull request, #4070:
URL: https://github.com/apache/nuttx-apps/pull/4070

   ## Summary
   
   Two small fixes in the crypto area:
   
   * `crypto/mbedtls/source/aes_alt.c`: initialize the CBC IV staging buffer 
unconditionally, so no code path can read it before the decryption branch fills 
it (defensive initialization; the buffer is normally written before use).
   * `testing/drivers/crypto/aescmac.c`: the success message printed `aescbc 
test N ok` - a copy-paste from the CBC test. The failure messages were already 
correct.
   
   ## Impact
   
   * No functional change.
   
   ## Testing
   
   Board sim:crypto with `CONFIG_CRYPTO_MBEDTLS=y` and the aescmac test. 
Together with the kernel fix in apache/nuttx#21930 (which fixes the 
pre-existing AES-CMAC one-byte truncation) the test prints the corrected 
message and passes all four NIST cases:
   
   ```
   nsh> aescmac
   aescmac test 0 ok
   aescmac test 1 ok
   aescmac test 2 ok
   aescmac test 3 ok
   ```
   
   On plain master the message is now also correct; testcase 1 still fails 
there until apache/nuttx#21930 lands.
   
   `tools/checkpatch.sh -c -u -m -g <base>..HEAD` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to