casaroli opened a new pull request, #21962:
URL: https://github.com/apache/nuttx/pull/21962

   ## Summary
   
   `lm3s6965-ek:qemu-protected` gives the kernel image the first 128 KiB of 
flash (`kflash`). On master e9eefaa0e9a the kernel image is 8 bytes too large. 
The `Linux (arm-ti)` job of every PR fails with ``region `kflash' overflowed by 
8 bytes``, also for PRs that change no code of this configuration (#21942 
changes only x86_64 code). PRs that add a few bytes fail by more (16 bytes for 
#21944, 48 bytes for #21943).
   
   The kernel image had 88 bytes free before e9eefaa0e9a (#21924), which adds 
96 bytes to `uart_writev()`. The configuration has been near full for a long 
time, so any small kernel change now makes it overflow.
   
   This PR excludes six small procfs entries that this QEMU configuration does 
not use: `cpuinfo`, `iobinfo`, `meminfo`, `tcbinfo`, `uptime` and `version`. 
`CONFIG_FS_PROCFS_EXCLUDE_MEMDUMP` depends on `!FS_PROCFS_EXCLUDE_MEMINFO`, so 
`make savedefconfig` drops its line. The process entries (`/proc/<pid>`) stay, 
so `ps` works. Then 2936 bytes of `kflash` are free.
   
   ## Impact
   
   `lm3s6965-ek:qemu-protected` only. No code change. `/proc/cpuinfo`, 
`/proc/iobinfo`, `/proc/meminfo`, `/proc/memdump` (excluded already), 
`/proc/tcbinfo`, `/proc/uptime` and `/proc/version` are not there. NSH leaves 
out the `free` command, because it reads `/proc/meminfo`. The NSH `uptime`, 
`uname` and `ps` commands do not read these entries (`sysinfo()`, `uname()` and 
`/proc/<pid>`). No program of this configuration (NSH, ostest, the ELF, module, 
hello and nettest examples, ping, dhcpc, dd) reads them.
   
   ## Testing
   
   Make build as in `tools/testbuild.sh`, in the CI docker image 
(`apache-nuttx-ci-linux`, Arm GNU Toolchain 13.2.Rel1, 
`CONFIG_ARM_TOOLCHAIN_GNU_EABI`), source in `/github/workspace/sources` as in 
CI, nuttx-apps master 72937e7f8. Each PR is merged on master e9eefaa0e9a as CI 
does. To measure an image that does not fit, `kflash` was made larger for the 
measurement only. Bytes used of the 131072-byte `kflash`:
   
   | Tree | `kflash` used | Free |
   |---|---|---|
   | master 5d150b4109e (before #21924) | 130984 | 88 |
   | master e9eefaa0e9a | 131080 | 8 bytes over |
   | master + #21944 | 131080 | 8 bytes over |
   | master + #21943 | 131112 | 40 bytes over |
   | master + this PR | 128136 | 2936 |
   | this PR + #21944 + #21943 + #21929 (on #21904) | 128192 | 2880 |
   
   The CI runs show 8 bytes more than this table for #21944 and #21943 (16 and 
48 bytes over); the margin covers this.
   
   `tools/refresh.sh --silent` and `make savedefconfig` do not change the 
defconfig. The build with the real 128 KiB `kflash` links with no warning 
(`-Werror`). `tools/checkpatch.sh -c -u -m -g` passes.
   
   With this PR, QEMU 10.2.2 (`qemu-system-arm -M lm3s6965evb`, `nuttx.bin` and 
`nuttx_user.bin` at 0x20000) stops after the boot letters `ABCDEF` and gives no 
NSH prompt. Master 10ef71be55c stops in the same place, so NSH and ostest were 
not run on this configuration.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to