parthitce commented on PR #21456: URL: https://github.com/apache/nuttx/pull/21456#issuecomment-6956501664
> The body says "RH850 does not link without this change, so it is part of this PR.", but the compiler.h change is not in this PR now; it is in #21498. Without it, `builtin_original()` in `include/nuttx/compiler.h` names `memcpy` without the "_" prefix, and both defconfigs build with -Os, so `qemu-rh850-u2c:nsh` and `:citest` do not link if this PR merges first. Fix: add `depends-on: apache/nuttx/pull/21498` to the body. > > The body still describes the old content: "v850 GCC prefixes C symbols with "_", so compiler.h now uses the compiler's user label prefix in the asm names of the builtin and fortify wrappers.", "compiler.h: same symbols and code on targets without a user label prefix (checked on sim and ARM, see Testing).", "CI builds both and runs ostest under QEMU through citest." and "CI: the Linux image gets the RH850 toolchain and QEMU." This PR has no compiler.h, Dockerfile or testlist change now. Fix: remove these lines, and say that compiler.h is in #21498, the CI image in #21497, and that the testlist entries come in a later PR. Thanks. #21498 is merged now, so the link issue is gone. I updated the description: compiler.h was in #21498, the CI image is in #21497, and the testlist entries come in a later PR. citest is dropped too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
