This is an automated email from the ASF dual-hosted git repository.

xiaoxiang781216 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 03212998252325ad80e1082e74c0b94cb04b4a56
Author: chenzihan1 <[email protected]>
AuthorDate: Mon Jun 8 21:33:21 2026 +0800

    ring: add DEBUGASSERT for parameter validation in ring_init
    
    Add DEBUGASSERT(r != NULL && cap > 0 && cap <= RING_IDX_MASK) at the
    entry of ring_init_magic() to catch invalid parameters early.
    
    Signed-off-by: chenzihan1 <[email protected]>
---
 include/nuttx/ring.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/nuttx/ring.h b/include/nuttx/ring.h
index c6311643f02..31a452f8227 100644
--- a/include/nuttx/ring.h
+++ b/include/nuttx/ring.h
@@ -145,9 +145,9 @@
 
 #define RING_IDX_MASK    0xffffff
 
-/* Maximum ring capacity: must be power-of-2 and fit in 24-bit index space */
+/* Maximum ring capacity (fits in 24-bit index space) */
 
-#define RING_SIZE_MAX    (1u << 23)
+#define RING_SIZE_MAX    RING_IDX_MASK
 
 /* 32-bit RTS packed type: {cnt:8, idx:24} in a single atomic_t.
  *
@@ -610,6 +610,8 @@ static inline_function void ring_init_magic(FAR struct 
ring_s *r,
   irqstate_t flags;
   int32_t old_magic;
 
+  DEBUGASSERT(r != NULL && cap > 0 && cap <= RING_SIZE_MAX);
+
   flags = irq_save();
 
   do

Reply via email to