casaroli opened a new pull request, #21987:
URL: https://github.com/apache/nuttx/pull/21987

   ## Summary
   
   On master, `stm32n6570-dk:netnsh` (added by #21969) fails `make 
olddefconfig`, so the `Linux (arm-stm32-other)` job of CI fails in every PR of 
nuttx and nuttx-apps:
   
   ```
   warning: the value '' is invalid for STM32_PHYSR (defined at 
arch/arm/src/common/stm32/Kconfig.eth:91), which has type int -- assignment 
ignored
   make: *** [olddefconfig] Error 1
   ```
   
   The configuration uses `CONFIG_NET_PHYLIB`. With PHYLIB, the Ethernet v2 
driver (`stm32_eth_v2.c`) lets PHYLIB manage the PHY and does not use 
`CONFIG_STM32_PHYSR` and the `CONFIG_STM32_PHYSR_*` masks (they are only in its 
`!CONFIG_NET_PHYLIB` code). Kconfig still asked for them, and they have no 
default.
   
   Now Kconfig shows these options only when the driver uses them: without 
PHYLIB, or with the m3m4 v1 driver, which does not support PHYLIB.
   
   ## Impact
   
   Only configurations with `CONFIG_NET_PHYLIB` and the Ethernet v2 driver 
change; on master that is `stm32n6570-dk:netnsh`. Every other configuration 
keeps its `CONFIG_STM32_PHYSR*` options. No code change, no defconfig change, 
no documentation change.
   
   ## Testing
   
   nuttx master 5cc3bdef647 and nuttx-apps master, `make olddefconfig` and a 
normalization (`make savedefconfig`, compared with the defconfig) as CI does:
   
   | configuration | master | this PR |
   |---|---|---|
   | stm32n6570-dk:netnsh (PHYLIB) | olddefconfig fails (5 `STM32_PHYSR*` 
warnings) | OK, defconfig unchanged |
   | nucleo-n657x0-q:netnsh (no PHYLIB, sets `STM32_PHYSR*`) | OK | OK, 
defconfig unchanged |
   | stm32n6570-dk:nsh | OK | OK, defconfig unchanged |
   
   stm32n6570-dk:netnsh builds with Arm GNU 13.2.Rel1 and `-Werror` (text 
194456). `tools/checkpatch.sh -c -u -m -g` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to