Ouss4 commented on a change in pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r494329082
##########
File path: arch/arm/src/Makefile
##########
@@ -35,7 +35,7 @@
############################################################################
include $(TOPDIR)/Make.defs
-include chip/Make.defs
+-include chip/Make.defs
Review comment:
As I said above `clean_context` is used before linking the directories,
at that point chip/ doesn't exist.
##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -136,3 +136,36 @@ ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
CHIP_CSRCS += esp32_modtext.c
CMN_ASRCS += xtensa_loadstore.S
endif
+
+ifeq ($(CONFIG_ESP32_WIRELESS),y)
+WIRELESS_DRV_UNPACK = esp-wireless-drivers-3rdparty
+WIRELESS_DRV_ZIP = master.zip
+WIRELESS_DRV_URL =
https://github.com/espressif/esp-wireless-drivers-3rdparty/archive
Review comment:
> The point is that the build should be reproducible and using master
means that every build could be different since master changed in between. If
you later need to update the commit, a quick PR is all that is needed to change
the hash.
There isn't much going on in that repository, it consists mostly of static
libraries and header files. The risk of a huge change that would break this
config is low.
That said, the script will be updated once a release/tag is created, the
repo is relatively new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
