zyfeier opened a new pull request, #22001:
URL: https://github.com/apache/nuttx/pull/22001

   ## Summary
   
   **Why.** `SYSTEM_GNSSPPS` (apps `system/gnsspps`) depends on `PTP_CLOCK && 
CLOCK_ADJTIME && GNSSUTILS_MINMEA_LIB`. The `stm32f4discovery:gnsspps` 
configuration enables the first two but not `GNSSUTILS_MINMEA_LIB`, so 
`olddefconfig` drops `CONFIG_SYSTEM_GNSSPPS=y`: the configuration builds 
without the gnsspps application, and the CI defconfig normalization check fails 
for it on every PR that runs the arm-stm32f4-2 job. The configuration was added 
by #21857 together with apache/nuttx-apps#4050, which declares the dependency.
   
   **What.** Enable `CONFIG_GNSSUTILS_MINMEA_LIB` in the configuration.
   
   ## Impact
   
   - Only `stm32f4discovery:gnsspps` changes. It now actually contains the 
gnsspps application it was added for.
   - No other configuration, code or documentation is affected.
   
   ## Testing
   
   Host: Ubuntu x86_64, CI image `ghcr.io/apache/nuttx/apache-nuttx-ci-linux`, 
master b27c8384a21, apps cacbca22625.
   
   - `./tools/configure.sh stm32f4discovery:gnsspps && make savedefconfig`: 
output identical to the committed defconfig (before this change it dropped 
`CONFIG_SYSTEM_GNSSPPS=y`).
   - `make`: builds, flash 116632 B / 1 MB, `gnsspps_main` present in the image.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to