raiden00pl commented on PR #21931:
URL: https://github.com/apache/nuttx/pull/21931#issuecomment-6977937414

   @xiaoxiang781216 @GUIDINGLI @zhhyu7 
   
     7f04498f157 removes netdev_lock(dev) around the receive loop in
     netdev_upper_rxpoll_work(), so non-VLAN RX also runs without the device
     lock now.  netdev_upper_input() still expects the device locked, and
     netdev_upper_txavail_work() still takes it, so RX and TX race on
     dev->d_iob.
     
     Reproducer: sim with a bridged netdev, 4 host TCP connections echo
     256 KiB each through the node at the same time.  From 7f04498f157 on the
     node crashes in every run:
     
       Assertion failed : at file: /mm/iob/iob_copyin.c:69 task: hpwork
     
     The commit before it does not crash.  Restoring the lock around the loop
     removes the crash, but in RX_DIRECT mode it runs the VLAN device RX poll
     under the real device lock again.  How do you want to keep VLAN RX off
     the real device lock while non-VLAN RX keeps it?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to