xiaoxiang781216 commented on code in PR #22093: URL: https://github.com/apache/nuttx/pull/22093#discussion_r4638401681
########## include/nuttx/sched.h: ########## @@ -40,8 +40,9 @@ #include <time.h> #include <nuttx/addrenv.h> -#include <nuttx/clock.h> #include <nuttx/irq.h> +#include <nuttx/percpu.h> Review Comment: drop too ########## include/nuttx/percpu.h: ########## @@ -0,0 +1,59 @@ +/**************************************************************************** + * include/nuttx/percpu.h Review Comment: drop, let's @zyfeier upstream percpu and bmp related patch and postpone the upstream of patches which depend on percpu. ########## sched/misc/assert.c: ########## @@ -118,20 +118,18 @@ #ifdef CONFIG_SMP static noreturn_function int pause_cpu_handler(FAR void *arg); #endif +typedef uintptr_t last_regs_t[XCPTCONTEXT_REGS]; /**************************************************************************** * Private Data ****************************************************************************/ #ifdef CONFIG_SMP -static bool g_cpu_paused[CONFIG_SMP_NCPUS]; +static DEFINE_PER_CPU_BSS_SMP(bool, g_cpu_paused); Review Comment: postpone until percpu upstreamed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
