xiaoxiang781216 commented on code in PR #22047:
URL: https://github.com/apache/nuttx/pull/22047#discussion_r4639294702


##########
sched/sched/sched_setaffinity.c:
##########
@@ -82,7 +82,13 @@ int nxsched_set_affinity(pid_t pid, size_t cpusetsize,
 
   /* Make sure that affinity mask is valid */
 
-  if (*mask == 0)
+#ifdef CONFIG_BMP

Review Comment:
   do you study https://github.com/apache/nuttx/pull/12020 or some AutoSAR 
implementation? the approach in this PR isn't the real BMP mode, so please 
don't reuse this name which just make confusion, and incorporate your special 
action into SMP_DEFAULT_CPUSET==0 is a good choice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to