pangzhen1xiaomi opened a new pull request, #22106:
URL: https://github.com/apache/nuttx/pull/22106

   ## Summary
   
   * Why: `boards/arm/qemu/qemu-armv8r-aarch32/configs/nsh/defconfig`, added by
     #21858, still sets `CONFIG_NSH_ARCHINIT=y`. That option was removed from
     nuttx-apps, so `make savedefconfig` drops it and the defconfig
     normalization check of the build CI fails. Since #21858 was merged, every 
PR
     that runs `Linux (arm-other)` fails at this board, for example #22079:
   
     ```
     [1/1] Normalize qemu-armv8r-aarch32/nsh
     34d33
     < CONFIG_NSH_ARCHINIT=y
     Saving the new configuration file
     ...
     modified:   boards/arm/qemu/qemu-armv8r-aarch32/configs/nsh/defconfig
     ```
   
     The arm-other job of #21858 itself failed the same way; it finished after
     the PR had been merged.
   * What: remove the stale `CONFIG_NSH_ARCHINIT=y`. Board initialization does
     not change: `BOARD_LATE_INITIALIZE` defaults to `y`, and
     `board_late_initialize()` in `qemu_boardinit.c` calls `qemu_bringup()`.
   * Related: #21858 (introduced the defconfig), #18833 (removed the other
     `NSH_ARCHINIT` mentions from board configs), #22079 (failing CI example).
   
   ## Impact
   
   * Is new feature added? Is existing feature changed? NO.
   * Impact on user (will user need to adapt to change)? NO.
   * Impact on build (will build process change)? NO. Only the generated
     `.config` loses an option that no longer exists.
   * Impact on hardware (will arch(s) / board(s) / driver(s) change)? NO code
     change; defconfig of `qemu-armv8r-aarch32:nsh` only.
   * Impact on documentation (is update required / provided)? NO.
   * Impact on security (any sort of implications)? NO.
   * Impact on compatibility (backward/forward/interoperability)? NO.
   * Anything else to consider or add? NO.
   
   ## Testing
   
   I confirm that changes are verified on local setup and works as intended:
   * Build Host(s): Ubuntu 22.04.5 LTS, x86_64, arm-none-eabi-gcc 13.2.1,
     host gcc 13.4.0, QEMU 10.2.1.
   * Target(s): qemu-armv8r-aarch32:nsh (QEMU Cortex-R52); sim:nsh and sim:smp
     for regression.
   
   Reproduced the CI check on master and on this branch:
   `tools/configure.sh -l qemu-armv8r-aarch32:nsh`, `make`, `make savedefconfig`
   and `diff` against the board defconfig. The image was then booted with:
   
   ```
   qemu-system-arm -M virt,virtualization=on,highmem=off,gic-version=3 \
       -semihosting -nographic -cpu cortex-r52 -net none \
       -device loader,file=nuttx
   ```
   
   Testing logs before change:
   
   ```
   normalize diff lines: 1
   34d33
   < CONFIG_NSH_ARCHINIT=y
   
   NuttShell (NSH) NuttX-13.1.1-RC0
   nsh> uname -a
   NuttX 13.1.1-RC0 708c9c799b4 Nov 20 2026 14:55:24 arm qemu-armv8r-aarch32
   nsh> ls /proc
   /proc:
    0/
    1/
    3/
    cpuinfo
    fs/
    ...
   nsh> poweroff
   ```
   
   Testing logs after change:
   
   ```
   normalize diff lines: 0
   
   NuttShell (NSH) NuttX-13.1.1-RC0
   nsh> uname -a
   NuttX 13.1.1-RC0 708c9c799b4-dirty Nov 20 2026 14:55:42 arm 
qemu-armv8r-aarch32
   nsh> ls /proc
   /proc:
    0/
    1/
    3/
    cpuinfo
    fs/
    ...
   nsh> poweroff
   ```
   
   `text`/`data`/`bss` of `nuttx` are identical before and after (198824 / 976 /
   17280).
   
   Regression:
   
   ```
   checkpatch: rc=0
   [sim:nsh] make build: rc=0
   [sim:nsh] ostest: Exiting with status 0
   [sim:smp] make build: rc=0
   [sim:smp] ostest: Exiting with status 0
   [sim:nsh] cmake build: rc=0
   [qemu-armv8r-aarch32:nsh] cmake build: rc=0
   ```
   
   Only tested on QEMU; no hardware is involved in this change.
   
   ## PR verification Self-Check
   
   * [x] This PR introduces only one functional change.
   * [x] I have updated all required description fields above.
   * [x] My PR adheres to Contributing Guidelines and Documentation (git commit 
title and message, coding standard, etc).
   * [ ] My PR is still work in progress (not ready for review).
   * [x] My PR is ready for review and can be safely merged into a codebase.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to