ssekar15 commented on code in PR #21951:
URL: https://github.com/apache/nuttx/pull/21951#discussion_r4640738917


##########
arch/tricore/src/common/tricore_trapcall.c:
##########
@@ -303,16 +280,21 @@ int weak_function tricore_nmitrap(uint32_t tid, void 
*context, void *arg)
  *
  ****************************************************************************/
 
-void tricore_trapcall(volatile void *trap)
+noinstrument_function
+void tricore_trapcall(void *taddr, uint32_t tid, uint32_t tclass)
 {
+  struct tricore_trap_s trap;
   uintptr_t *regs;
   bool from_task;
 
-  struct tricore_trap_s *ctrap = (struct tricore_trap_s *)trap;
-  uint8_t tclass = ctrap->tclass;
-  unsigned int tid = ctrap->tid;
-
-  tricore_trapinfo(trap);
+  trap.taddr  = (uintptr_t)taddr;
+  trap.tid    = tid;
+  trap.tclass = tclass;
+  trap.tcpu   = up_cpu_index();

Review Comment:
   thanks, please make this PR depended on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to