chengkai15 commented on PR #3977: URL: https://github.com/apache/nuttx-apps/pull/3977#issuecomment-7038798076
@xiaoxiang781216 two things on this PR. **CI.** The red `Linux (arm-stm32l-u-g)` job in the last Build run ([44221383327](https://github.com/apache/nuttx-apps/actions/runs/44221383327)) is the upstream flash overflow, not this PR: ``` Configuration/Tool: nucleo-l432kc/wgen arm-none-eabi-ld: region `flash' overflowed by 564 bytes ``` `arm-other` was cancelled after that job failed. The fix is apache/nuttx#21975 (`boards/nucleo-l432kc: Disable four NSH file commands in wgen`), merged at 02:33 UTC on 11-18. The run fetched its sources at 02:16 UTC, so it did not include the fix. Builds of other PRs from 11-20 pass `arm-stm32l-u-g`. Re-running the failed jobs reuses the sources fetched on 11-18, so the overflow would come back. Could you start a fresh Build run instead (for example, close and reopen the PR)? That keeps the head at 239026a and the current approvals from @GUIDINGLI and @casaroli. If I push a rebase, both approvals are dismissed. **work.c.** About your question in https://github.com/apache/nuttx-apps/pull/3977#discussion_r4582535423 ("why not reuse work/usrwork"): I suggest merging this PR as it is and moving the port onto the NuttX work queue in a follow-up PR. That follow-up would add what the Zephyr host needs from `k_work` (running state and the related flags) through `work_queue_create`. The change touches nuttx as well as apps, and it can be reviewed on its own. Is that OK with you, or do you want it in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
