cederom commented on PR #4092: URL: https://github.com/apache/nuttx-apps/pull/4092#issuecomment-7043235704
I would still fix the key store state mismatch between success and error run: * On success: every case ends with CRK_DELETE_KEY for each key id it allocated, so the key store ends up clean. Whether the kernel’s software key store wipes the bytes in flash or only marks the slot free is up to #22061. I didn’t check that, and for this test it doesn’t matter. * On failure: the case returns at its first error and main() exits without calling delete. Every id allocated so far stays allocated, and any already saved with CRK_SAVE_KEY stays in /dev/nvs. That survives the program exiting and, on real flash, a reboot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
