This is an automated email from the ASF dual-hosted git repository.

xiaoxiang781216 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 4fb4aef5cd1d3a61c94087a7460aecd2001c4bc6
Author: wangjianyu3 <[email protected]>
AuthorDate: Thu Feb 5 16:32:30 2026 +0800

    drivers/sensors/gnss: Fix a log format and leaked mutexes.
    
    The sminfo() in gnss_close() is missing the '%' before PRIu8, so the
    reference count is not printed, and gnss_unregister() never destroys
    upper->lock and upper->bufferlock.
    
    Add the missing '%' and destroy both mutexes in gnss_unregister().
    
    Signed-off-by: wangjianyu3 <[email protected]>
---
 drivers/sensors/gnss_uorb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/sensors/gnss_uorb.c b/drivers/sensors/gnss_uorb.c
index 6daaff37cb4..e1d44b08c3c 100644
--- a/drivers/sensors/gnss_uorb.c
+++ b/drivers/sensors/gnss_uorb.c
@@ -318,7 +318,7 @@ static int gnss_close(FAR struct file *filep)
         }
 
       upper->crefs--;
-      sminfo(filep->f_inode->i_name, "crefs " PRIu8 "", upper->crefs);
+      sminfo(filep->f_inode->i_name, "crefs %" PRIu8 "", upper->crefs);
     }
 
   list_delete(&user->node);
@@ -932,6 +932,8 @@ void gnss_unregister(FAR struct gnss_lowerhalf_s *lower, 
int devno)
   sensor_unregister(&upper->dev[SENSOR_GNSS_IDX_GNSS_GEOFENCE].lower, devno);
   snprintf(path, PATH_MAX, GNSS_PATH_FMT, devno);
   unregister_driver(path);
+  nxmutex_destroy(&upper->lock);
+  nxmutex_destroy(&upper->bufferlock);
   nxsem_destroy(&upper->buffersem);
   circbuf_uninit(&upper->buffer);
   lib_put_pathbuffer(path);

Reply via email to