ssekar15 commented on code in PR #22126:
URL: https://github.com/apache/nuttx/pull/22126#discussion_r4652315061


##########
arch/tricore/src/common/tricore_fork.c:
##########
@@ -243,6 +243,10 @@ pid_t up_fork(bool vfork)
   struct fork_s context;
   uintptr_t *csa_addr;
 
+  /* Preserve the return value across the lower context restore. */
+
+  volatile pid_t ret;

Review Comment:
   volatile for local variable would look strange, we already use asm lower 
contex restore and just mandate only needed reg.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to